Global styles: update return values from getGlobalStylesChanges() #58707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es. This includes adding a period at the end of any sentences.
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNIf you're a Core Committer, use this list when committing to GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
commented
Feb 6, 2024
| @@ -36,7 +36,7 @@ function ChangesSummary( { revision, previousRevision } ) { | |||
| data-testid="global-styles-revision-changes" | |||
| className="edit-site-global-styles-screen-revisions__changes" | |||
| > | |||
| { changes.join( ', ' ) } | |||
| { changes.join( ', ' ) }. | |||
There was a problem hiding this comment.
Pretty crude but it was the simplest approach after having tried the following:
- passing a "suffix" option value of
"."togetGlobalStylesChanges(). Rejected because the function returns an array of strings and requires appending the suffix to the last item. Too weird. - Changing the return value of
getGlobalStylesChanges()to be a joined string. Rejected because it removes all the flexibility of astring[]return value. - Creating a new function to return
changes.join( ', ' ) }.. Rejected, or at least postponed, until we need it. We're only usinggetGlobalStylesChanges()in two places.
In summary, I'm of the opinion that the component should decide how to present the changes.
There was a problem hiding this comment.
Since we're already using , to join the changes together, I think appending a . character here is likely fine!
ramonjd
changed the title
|
Size Change: -10 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7a79094. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7794124238
|
andrewserong
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
"Audio"vs"Audio block"Why?
Design feedback from:
Also, let's leave it up to the consuming component as to how to present the changes.
Testing Instructions
Screenshots or screencast